Keeps the reader's place when a link only changes the page's own query #48

Merged
miko merged 1 commit from feat/swap-keep-scroll into main 2026-11-01 00:37:50 +00:00
Owner

Every in-place swap landed at the top of the page, so the Profit page's option links (fee deep-dive, scale, turnover readout, spans, grain, owner) threw the reader back to the top on every switch. A navigation whose target path equals the current path now keeps the scroll position, and the pushed history entry records it; a link to a different page still starts at the top. Verified in Chromium (Blink): fee deep-dive at scroll 505 stays 505, Indexed at 179 stays 179, Retention % at 1007 stays 1007. All 122 JS tests pass.

Every in-place swap landed at the top of the page, so the Profit page's option links (fee deep-dive, scale, turnover readout, spans, grain, owner) threw the reader back to the top on every switch. A navigation whose target path equals the current path now keeps the scroll position, and the pushed history entry records it; a link to a different page still starts at the top. Verified in Chromium (Blink): fee deep-dive at scroll 505 stays 505, Indexed at 179 stays 179, Retention % at 1007 stays 1007. All 122 JS tests pass.
Keeps the reader's place when a link only changes the page's own query
All checks were successful
github/analysis Analysis gate on GitHub runners
github/test Test gate on GitHub runners
github/core-only Core-only gate on GitHub runners
github/race Race gate on GitHub runners
7f226d0242
miko merged commit 0b4221157c into main 2026-11-01 00:37:50 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
EveSynapse/evesynapse!48
No description provided.