Pins a chart tooltip on a plain tap so tapping off the chart dismisses it #46

Merged
miko merged 1 commit from feat/chart-tip-dismiss into main 2026-11-01 00:43:23 +00:00
Owner

A tap on a scrubbable chart showed the tooltip without pinning it: the drag-end path was the only one that pinned, and the click-off dismissal only answers for a pinned tip, so a plain tap left a tooltip on screen that nothing could close. The press-end handler now treats an unmoved tap as a toggle (pins an unpinned tip, releases the pinned one) and a drag as a pin as before, and swallows the trailing click of the gesture in both cases. Verified in Chromium (Blink) against the Profit charts: tap pins, tap off closes, tap on the same point closes, drag pins, tap off closes.

A tap on a scrubbable chart showed the tooltip without pinning it: the drag-end path was the only one that pinned, and the click-off dismissal only answers for a pinned tip, so a plain tap left a tooltip on screen that nothing could close. The press-end handler now treats an unmoved tap as a toggle (pins an unpinned tip, releases the pinned one) and a drag as a pin as before, and swallows the trailing click of the gesture in both cases. Verified in Chromium (Blink) against the Profit charts: tap pins, tap off closes, tap on the same point closes, drag pins, tap off closes.
Pins a chart tooltip on a plain tap so tapping off the chart dismisses it
All checks were successful
github/analysis Analysis gate on GitHub runners
github/core-only Core-only gate on GitHub runners
github/race Race gate on GitHub runners
github/test Test gate on GitHub runners
527ca66c05
miko merged commit ba7b761389 into main 2026-11-01 00:43:23 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
EveSynapse/evesynapse!46
No description provided.