Gives every notification kind its own notification and briefing card switches

natemsz commented

2026-11-01 05:51:36 +00:00

Owner

Each event kind that can be a notification, a briefing card, or both now has two independent per-user switches in notification settings: notifications on or off, and briefing card on or off. Together they give notification only, card only, both, or neither. The card switch is account level. Channel choices for notifications stay as they are.

Storage stays in the existing notification preferences. The save uses the same shown-marker pattern as the channel switches, so submitting the form with every box unticked still saves as all off. Notification creation and delivery check the notification switch. The briefing builder checks the card switch after dismissal bookkeeping, so a stored dismissal survives the card being switched off and back on. Kinds with no card show No card instead of a dead switch.

New kinds in this round:

Undercut digest: digest only, never one notification per beaten order, with a per-user maximum frequency enforced when the digest is built. Opens My Orders. No undercut tool page.
Gate camp alerts: for systems the user chooses in settings, fired only while one of their characters is online. Has a card and a notification.
Contract events: accepted, finished, and expired, courier included. Deduped on contract and event so repeat polls do not notify twice. Has a card and a notification.
Re-login needed: fires once on the transition when a token is parked dead on a definitive invalid_grant, not on every worker cycle. Has a card and a notification, and the hint on the character itself is plainer.
Industry job done keeps its existing notification and follows the same routing.

Two things to flag. The briefing deck cap moves from 12 to 14 because the new contract and camp cards pushed a dense fixture over the cap and hid the mail card. And TestBriefingFontPreloadAndFooter fails on clean main too (font 404), so that failure predates this branch.

Gate: gofmt clean, go vet clean, targeted suites pass (settings, notify routing, briefing routing). No version.txt changes.

Each event kind that can be a notification, a briefing card, or both now has two independent per-user switches in notification settings: notifications on or off, and briefing card on or off. Together they give notification only, card only, both, or neither. The card switch is account level. Channel choices for notifications stay as they are. Storage stays in the existing notification preferences. The save uses the same shown-marker pattern as the channel switches, so submitting the form with every box unticked still saves as all off. Notification creation and delivery check the notification switch. The briefing builder checks the card switch after dismissal bookkeeping, so a stored dismissal survives the card being switched off and back on. Kinds with no card show No card instead of a dead switch. New kinds in this round: - Undercut digest: digest only, never one notification per beaten order, with a per-user maximum frequency enforced when the digest is built. Opens My Orders. No undercut tool page. - Gate camp alerts: for systems the user chooses in settings, fired only while one of their characters is online. Has a card and a notification. - Contract events: accepted, finished, and expired, courier included. Deduped on contract and event so repeat polls do not notify twice. Has a card and a notification. - Re-login needed: fires once on the transition when a token is parked dead on a definitive invalid_grant, not on every worker cycle. Has a card and a notification, and the hint on the character itself is plainer. - Industry job done keeps its existing notification and follows the same routing. Two things to flag. The briefing deck cap moves from 12 to 14 because the new contract and camp cards pushed a dense fixture over the cap and hid the mail card. And TestBriefingFontPreloadAndFooter fails on clean main too (font 404), so that failure predates this branch. Gate: gofmt clean, go vet clean, targeted suites pass (settings, notify routing, briefing routing). No version.txt changes.

natemsz added 1 commit

2026-11-01 05:51:36 +00:00

Gives every notification kind its own notification and briefing card switches

github/analysis Analysis gate on GitHub runners

Details

github/core-only Core-only gate on GitHub runners

Details

github/test Test gate on GitHub runners

Details

github/race Race gate on GitHub runners

Details

6a5feac393

Each kind that can appear as a notification, a briefing card, or both now has two independent per-user switches in notification settings, so each user can pick notification only, card only, both, or neither. The choices live in the existing notification preferences and the save keeps an all-off state. The briefing builder checks the card switch after dismissal bookkeeping, and creation and delivery check the notification switch.

New kinds: undercut digest (digest only, with a per-user maximum frequency, opens My Orders), gate camp alerts for chosen systems (online characters only, card and notification), contract accepted, finished, and expired including courier (deduped per contract and event, card and notification), and re-login needed on a definitive invalid_grant (fires once on the transition, card and notification, with a plainer hint on the character). Industry job done follows the same routing.

natemsz added 1 commit

2026-11-02 03:54:03 +00:00

Include the kinds marker when the push test switches a kind off

github/analysis Analysis gate on GitHub runners

Details

github/test Test gate on GitHub runners

Details

github/core-only Core-only gate on GitHub runners

Details

github/race Race gate on GitHub runners

Details

a5b98469e3