Sizes the trained banner to its content

miko commented

2026-11-02 02:17:09 +00:00

Owner

The trained-since-last-visit banner on the Pilot Overview sized itself to its dismiss button, not to its entries. The button is classless, so the shared button rule in style.css gives it the control-height floor (min-height: var(--control-h), 2.5rem on touch pointers via phone.css, 1.9rem on fine pointers). The banner rule overrode the button padding, border and background but never its min-height, so one trained entry rendered in a strip 61.2px tall around 22px of content on touch devices (measured in Chromium (Blink) against the demo account: chip 21.9px, entry 20.4px, dismiss form 40px).

The fix adds min-height: 0 to .ov-bx button in overview.css, the same treatment .btn.small already uses for inline buttons. Nothing else changes: same markup, colors, text, + Plan markers, and the dismiss control and its behavior.

Measured after, one entry: 45.2px at desktop and middle widths (was 61.2px), wrapping rows on phone size to their content. The two-entry banner on one row drops by the same 16px (61.2 to 45.2px), since the same button floor padded its first row.

Targeted tests as pgtester: the trained banner and character sheet tests in internal/app, and the full internal/app/tests black-box package, all pass.

The trained-since-last-visit banner on the Pilot Overview sized itself to its dismiss button, not to its entries. The button is classless, so the shared button rule in style.css gives it the control-height floor (min-height: var(--control-h), 2.5rem on touch pointers via phone.css, 1.9rem on fine pointers). The banner rule overrode the button padding, border and background but never its min-height, so one trained entry rendered in a strip 61.2px tall around 22px of content on touch devices (measured in Chromium (Blink) against the demo account: chip 21.9px, entry 20.4px, dismiss form 40px). The fix adds min-height: 0 to .ov-bx button in overview.css, the same treatment .btn.small already uses for inline buttons. Nothing else changes: same markup, colors, text, + Plan markers, and the dismiss control and its behavior. Measured after, one entry: 45.2px at desktop and middle widths (was 61.2px), wrapping rows on phone size to their content. The two-entry banner on one row drops by the same 16px (61.2 to 45.2px), since the same button floor padded its first row. Targeted tests as pgtester: the trained banner and character sheet tests in internal/app, and the full internal/app/tests black-box package, all pass.

miko added 1 commit

2026-11-02 02:17:09 +00:00

Sizes the trained banner to its content

github/analysis Analysis gate on GitHub runners

Details

github/core-only Core-only gate on GitHub runners

Details

github/test Test gate on GitHub runners

Details

github/race Race gate on GitHub runners

Details

0f1027b42b