Keeps the character scope panel open while the selection is edited #96

Merged
miko merged 1 commit from fix/charselector-flow into main 2026-11-02 05:52:47 +00:00
Owner

Fixes the Assets character scope flow. The scope checklist moves into the shared character selector as its multi mode (a new charselectormulti define in charselector.html; assets.html renders it).

Rows edit a pending set in place: the panel stays open across any number of toggles with no navigation, Done commits the set with one navigation, and closing the panel (button, outside click, Escape) discards uncommitted edits. Every row gains an Only link that scopes the page to that character in one pick. The panel header gains All and None actions over the whole list, ignoring the current search filter, plus a live count of the pending set; Done stays disabled at an empty set because an empty scope reads back as all characters. Without scripts the rows keep working as one-toggle-per-load links. Search by name and tags is unchanged, and the single-pick selector on the Character Overview and every other page is unchanged.

Gate: gofmt clean, go build ./... and go vet pass, node --check on app.js passes. Targeted tests as pgtester pass: TestAssetsScopeSelectorChecklist (pins updated for the row data-id and the new controls), TestAssetsMatrixFilesShipsAndCans, TestAllTemplatesParse, TestStaticServesMinifiedCSS, TestCSSDeclarations, TestAssetLinks. A driven browser sequence against the demo rig passes 32 checks: three toggles in one open session with the URL and DOM untouched, counts at each step, None then All, Done committing the pair in one navigation, Only landing on the single scope, discard on close, and the Overview single pick navigating in one click.

Fixes the Assets character scope flow. The scope checklist moves into the shared character selector as its multi mode (a new charselectormulti define in charselector.html; assets.html renders it). Rows edit a pending set in place: the panel stays open across any number of toggles with no navigation, Done commits the set with one navigation, and closing the panel (button, outside click, Escape) discards uncommitted edits. Every row gains an Only link that scopes the page to that character in one pick. The panel header gains All and None actions over the whole list, ignoring the current search filter, plus a live count of the pending set; Done stays disabled at an empty set because an empty scope reads back as all characters. Without scripts the rows keep working as one-toggle-per-load links. Search by name and tags is unchanged, and the single-pick selector on the Character Overview and every other page is unchanged. Gate: gofmt clean, go build ./... and go vet pass, node --check on app.js passes. Targeted tests as pgtester pass: TestAssetsScopeSelectorChecklist (pins updated for the row data-id and the new controls), TestAssetsMatrixFilesShipsAndCans, TestAllTemplatesParse, TestStaticServesMinifiedCSS, TestCSSDeclarations, TestAssetLinks. A driven browser sequence against the demo rig passes 32 checks: three toggles in one open session with the URL and DOM untouched, counts at each step, None then All, Done committing the pair in one navigation, Only landing on the single scope, discard on close, and the Overview single pick navigating in one click.
Keeps the character scope panel open while the selection is edited
All checks were successful
github/analysis Analysis gate on GitHub runners
github/core-only Core-only gate on GitHub runners
github/test Test gate on GitHub runners
github/race Race gate on GitHub runners
3b103d9b70
The Assets scope checklist now lives in the shared character selector as its multi mode. Ticking rows edits a pending set in place with the panel held open, Done commits the set in one navigation, and closing the panel discards the pending set. Each row gains an Only link that scopes the page to that character in one pick, and the panel header gains All and None actions over the whole list plus a live selected count. Without scripts the rows keep working as per-load toggle links.
miko merged commit d9bf7bab3d into main 2026-11-02 05:52:47 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
EveSynapse/evesynapse!96
No description provided.