Fixes broken item icons for skins and blueprints #99

Merged

miko merged 1 commit from fix/icon-404-skins into main

2026-11-02 05:57:58 +00:00

miko commented

2026-11-02 05:12:39 +00:00

Owner

Item icons resolve per type category at the shared resolver:

Permanent SKIN types have no image in any variant on the image server (icon, render, blueprint and copy all answer 404), so skins resolve to a shared local placeholder. The app stores no skin to hull mapping, so skins do not borrow a hull picture.
Blueprints use the blueprint image variant, which answers 200, instead of the icon variant, which answers 400.
The fallback image the templates reference, /static/img/item.svg, now exists, so an icon that fails loads the placeholder instead of the broken image glyph.

Ships keep the render variant and all other types keep the icon variant. Resolution stays a stored data and URL pattern concern: no per-render external calls. Verified with the contracts icon tests and the targeted Assets and LP tests.

Item icons resolve per type category at the shared resolver: - Permanent SKIN types have no image in any variant on the image server (icon, render, blueprint and copy all answer 404), so skins resolve to a shared local placeholder. The app stores no skin to hull mapping, so skins do not borrow a hull picture. - Blueprints use the blueprint image variant, which answers 200, instead of the icon variant, which answers 400. - The fallback image the templates reference, /static/img/item.svg, now exists, so an icon that fails loads the placeholder instead of the broken image glyph. Ships keep the render variant and all other types keep the icon variant. Resolution stays a stored data and URL pattern concern: no per-render external calls. Verified with the contracts icon tests and the targeted Assets and LP tests.

miko added 1 commit

2026-11-02 05:12:39 +00:00

Fixes broken item icons for skins and blueprints and adds the shared fallback image

github/analysis Analysis gate on GitHub runners

Details

github/core-only Core-only gate on GitHub runners

Details

github/test Test gate on GitHub runners

Details

github/race Race gate on GitHub runners

Details

8e564941bd

Permanent SKIN types have no image in any variant on the image server, so skins resolve to a shared local placeholder. Blueprints use the blueprint image variant instead of the icon variant, which answers 400. The fallback image the templates point at now exists, so any icon that fails loads the placeholder instead of the broken image glyph.

miko merged commit 19be18846c into main

2026-11-02 05:57:58 +00:00

miko referenced this pull request from a commit

2026-11-02 05:57:59 +00:00

Merge pull request 'Fixes broken item icons for skins and blueprints' (#99) from fix/icon-404-skins into main